Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix CSV count with comment prefix skipped empty lines #21577

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: Fix CSV count with comment prefix skipped empty lines #21577

merged 2 commits into from
Mar 4, 2025
+67 −23

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Mar 4, 2025 •
edited
Loading

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 4, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.43%. Comparing base (b9a5bc0) to head (834da78).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/csv/read/parser.rs 61.76% 13 Missing ⚠️
crates/polars-mem-engine/src/executors/scan/csv.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #21577   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files        1602     1602           
  Lines      230574   230595   +21     
  Branches     2636     2636           
=======================================
+ Hits       183164   183183   +19     
- Misses      46799    46801    +2     
  Partials      611      611

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review March 4, 2025 05:50
@ritchie46 ritchie46 merged commit f9b9a0d into pola-rs:main Mar 4, 2025
30 checks passed
anath2 pushed a commit to anath2/polars that referenced this pull request Mar 5, 2025
@nameexhaustion @anath2
fix: Fix CSV count with comment prefix skipped empty lines (pola-rs#2…
331ebc1 
…1577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV select(len) does not count empty lines when comment prefix specified
2 participants
@nameexhaustion @ritchie46